play-services-plugins icon indicating copy to clipboard operation
play-services-plugins copied to clipboard

Use plugin in multi module project

Open MitjaHenner opened this issue 6 years ago • 6 comments

When I use the license plugin in the app module of a multi module project im not getting all the dependencies.

Is there a solution to this?

I thought about adding it to every module but since they are all library modules the plugin doesn't work.

MitjaHenner avatar Sep 04 '18 13:09 MitjaHenner

I've got a rather large revamp of the plugin dependency logic at https://github.com/paulrashidi/play-services-plugins/tree/refactor_dep_checking

It should support multi-module use although you should only really need it for your APK modules.

If you want you can see if it resolves things for you. There are instructions in the pull request I have going for it: https://github.com/google/play-services-plugins/pull/11#commitcomment-30466967

PaulRashidi avatar Sep 17 '18 19:09 PaulRashidi

Im sorry, I was talking about the oss-plugin, its a bit confusing with two plugins on here.

MitjaHenner avatar Sep 21 '18 06:09 MitjaHenner

Perhaps this is related to issue 25? Do the POM files of the missing dependencies have licenses tags?

sperzion avatar Nov 29 '18 02:11 sperzion

@MitjaHenner have you tried specifying your other module dependencies like this: implementation project(path: ':submodule', configuration: 'default')? See issue 25.

sperzion avatar Mar 27 '19 19:03 sperzion

@MitjaHenner have you tried specifying your other module dependencies like this: implementation project(path: ':submodule', configuration: 'default')? See issue 25.

com.android.tools.build:gradle:3.4.0 gradle-5.1.1-all.zip

I think adding "configuration: 'default'" does not work anymore in recent Gradle version. The project compiles with

implementation project(path: ':submodule')

but not with

implementation project(path: ':submodule', configuration: 'default')

JarmoKukkola avatar May 12 '19 13:05 JarmoKukkola

does anybody have any news regarding this issue? I'm seeing the same problem as @JarmoKukkola

lukas1 avatar Jan 10 '20 16:01 lukas1