play-services-plugins icon indicating copy to clipboard operation
play-services-plugins copied to clipboard

Publish plugin marker artifacts for use with plugins DSL

Open technoir42 opened this issue 5 years ago • 9 comments

To use this syntax aka plugins DSL the plugin must have a corresponding marker artifact in one of the plugin repositories:

plugins {
    id 'com.google.gms.google-services' version '4.2.0'
}

Also instead of using buildscript block one would have to add Google's Maven as a plugin repository in their settings.gradle:

pluginManagement {
    repositories {
        gradlePluginPortal()
        google()
    }
}

PR for google-services-plugin

technoir42 avatar May 03 '19 21:05 technoir42

@technoir42 has this been released already? Because I get Plugin [id: 'com.google.gms.google-services', version: '4.2.0'] was not found in any of the following sources

wbervoets avatar May 17 '19 10:05 wbervoets

Not yet, I used version 4.2.0 as an example.

technoir42 avatar May 17 '19 10:05 technoir42

Ah, okay because the docs were updated (README.md) I thought it was

wbervoets avatar May 17 '19 10:05 wbervoets

Whats the status on this? Im still getting could not resolve plugin artifact

milis92 avatar Jan 29 '20 13:01 milis92

Any update on this one? Apparently the code has been merged, but the plugin marker artifact never got published

plnice avatar Nov 16 '21 15:11 plnice

@davidmotson sorry for mentioning directly, but I've seen that you are involved in a similar task for Firebase (https://github.com/firebase/firebase-android-sdk/issues/3125#issuecomment-966711911) which is going to be released soon, and you also contributed some code to the google-services plugin - so will you be able to also have a look at the plugin marker artifact support for google-services? I could completely get rid of buildscript block in my project when plugin markers are released for both Firebase plugins and google-services.

plnice avatar Nov 17 '21 11:11 plnice

According to this comment this should be fixed (with the current version): https://github.com/google/play-services-plugins/issues/207#issuecomment-992943558

I am not sure how to verify that the plugin marker is actually available in the maven repo. Can you guys confirm this?

G00fY2 avatar Jan 07 '22 19:01 G00fY2

@technoir42 Apologies for the ping, but are there any plans on getting the other 2 plugins oss-licenses-plugin and strict-version-matcher-plugin updated with plugin markers? I've noticed that in the PR #51 you've mentioned that you're planning to update the last 2 plugins as well. 😅

EDIT: I've since created a PR #222 that aims to publish a plugin marker for the OSS Licenses plugin

EdricChan03 avatar Apr 07 '22 18:04 EdricChan03

Link #223.

Goooler avatar Sep 04 '22 09:09 Goooler