play-services-plugins icon indicating copy to clipboard operation
play-services-plugins copied to clipboard

org.gradle.java.home should not be a project-level

Open doug-precocity opened this issue 6 years ago • 1 comments

Describe the bug Attempting to build the project produces the following error:

Value '/usr/local/buildtools/java/jdk8/' given for org.gradle.java.home Gradle property is invalid (Java home supplied is invalid)

This is because org.gradle.java.home is defined in the gradle.properties file included in the project. Since the location of Java will differ from one user's machine to the next, this property should be defined as a local user property, not a project property. The path Java should be configured via the JAVA_HOME environment variable or a gradle properties file that is not checked into version control.

To Reproduce Steps to reproduce the behavior:

  1. git clone https://github.com/google/play-services-plugins.git
  2. cd play-services-plugins/google-services-plugin
  3. gradle build

Expected behavior builds successfully

doug-precocity avatar Dec 10 '18 19:12 doug-precocity

Thanks for the report. There's an in-progress PR from @TacoTheDank (thanks TacoTheDank!) https://github.com/google/play-services-plugins/pull/33/files#diff-16b500feb7ba5b406b53040efc7b17ac, which should address this.

zhiqiao avatar Jan 18 '19 17:01 zhiqiao