Support third party licenses

[joostfunkekupper]

This PR is based on the open #143 which hasn't been updated in a while. I've also included some instructions on how to manually add third party licenses that were not picked up through Maven.

[google-cla[bot]]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[joostfunkekupper]

@googlebot I signed it!

[google-cla[bot]]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[joostfunkekupper]

Hi @ganadist, would you be interested in approving the use of your commits? I'm really hoping to get your changes approved and merged, since it's been very useful in our production apps.

[rekire]

Any chance that you can add the dependency management of the play services like in LicensesTask.addGooglePlayServiceLicenses(...)?

[joostfunkekupper]

Any chance that you can add the dependency management of the play services like in LicensesTask.addGooglePlayServiceLicenses(...)?

Could you elaborate? The Google Play Services licenses are already being added by this library.

[rekire]

I mean that any dependency can use that way to add own licenses with those two files. It should be simple to check if those two files exists in any dependency and not exclusive for the play services dependencies.

[rekire]

By the way I found a better way for what I'm aiming I created the PR #191 that will take the name directly from the POM file. Never mind my request. :-)

[joostfunkekupper]

By the way I found a better way for what I'm aiming I created the PR #191 that will take the name directly from the POM file. Never mind my request. :-)

Yeah right, nice.

[rekire]

@joostfunkekupper you need to update/rebase your PR. Mine was merged in the meantime. You might should add also one or more tests to make sure that everything works as expected.

[joostfunkekupper]

Thanks @rekire for letting me know. I'll try and get onto that asap.

[google-cla[bot]]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[google-cla[bot]]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[joostfunkekupper]

Hello @ganadist. Sorry to bug you again about this, but could you reply with @googlebot I consent. to this PR so that the google-cla bot can approve your commits to be part of this PR.

[google-cla[bot]]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[ganadist]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

information_source Googlers: Go here for more info.

@googlebot I consent.

[google-cla[bot]]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[joostfunkekupper]

Sorry @ganadist, your reply should only include @googlebot I consent. and nothing else :) The bot isn't very smart

[google-cla[bot]]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[ganadist]

@googlebot I consent.

[joostfunkekupper]

Hi @caller9, this PR is ready to be reviewed. Documentation and test case are included.

[juliankotrba]

Hi @caller9, any update on this PR? I would really appreciate if the changes from @joostfunkekupper and @ganadist get merged soon. Thanks!

cc @PaulRashidi

[mobilemarines]

Hey guys, thanks for this important feature. I would really appreciate a release as https://github.com/cookpad/LicenseToolsPlugin was deprecated in favor of this license plugin. It's open for quite some time and licenses are a legal requirement. So I think it would help a lot of people to provide this feature soon because alternatives are deprecated. Especially hybrid apps use licenses outside the normal scope and need to show them, too.

[wseemann]

Hey guys, thanks for this important feature. I would really appreciate a release as https://github.com/cookpad/LicenseToolsPlugin was deprecated in favor of this license plugin. It's open for quite some time and licenses are a legal requirement. So I think it would help a lot of people to provide this feature soon because alternatives are deprecated. Especially hybrid apps use licenses outside the normal scope and need to show them, too.

@mobilemarines I recommend using AboutLibraries. It's fully Open Source (unlike this plugin), it's actively maintained, and provides the exact same functionality as the play services plugin.