pcbdl icon indicating copy to clipboard operation
pcbdl copied to clipboard

Fix svg exporting

Open maxschommer opened this issue 5 years ago • 2 comments

Adding a draft PR to fix SVG exporting.

  • Changed function generate_svg to write to a file or multiple files
  • Added test cases for generate_svg which checks for exported SVG files
  • Changed some print functions to logging calls to not clutter the stdout when generating SVG files

The main issue with generate_svg seemed to be that it never attempted to write to a file as documented. The user was also given no indications that it failed to generate any output.

maxschommer avatar Nov 23 '20 02:11 maxschommer

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Nov 23 '20 02:11 google-cla[bot]

@googlebot I signed it!

maxschommer avatar Nov 23 '20 02:11 maxschommer