osv-scanner icon indicating copy to clipboard operation
osv-scanner copied to clipboard

implement filtering by packages through the config

Open josieang opened this issue 1 year ago • 4 comments

I'd like feedback on the config yaml schema, the filter message and it's behaviour if the version is empty (it filters any version of that package).

This is in response to https://github.com/google/osv-scanner/issues/814

josieang avatar Apr 26 '24 05:04 josieang

I think I need a better way to filter based on semver parts. I know think deps.dev/util/semver does this, I will come back to it once I'm back from leave.

josieang avatar Apr 26 '24 08:04 josieang

Codecov Report

Attention: Patch coverage is 81.96721% with 11 lines in your changes missing coverage. Please review.

Project coverage is 65.18%. Comparing base (8fd553a) to head (78fe74d). Report is 1 commits behind head on main.

Files Patch % Lines
pkg/osvscanner/osvscanner.go 8.33% 10 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
+ Coverage   65.14%   65.18%   +0.04%     
==========================================
  Files         149      149              
  Lines       12338    12384      +46     
==========================================
+ Hits         8037     8072      +35     
- Misses       3849     3859      +10     
- Partials      452      453       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 07 '24 01:05 codecov-commenter

Was I supposed to provide a token?

https://github.com/google/osv-scanner/actions/runs/8978083643/job/24657957118

Error: Codecov token not found. Please provide Codecov token with -t flag.
Error: Codecov: Failed to properly create commit: The process '/Users/runner/work/_actions/codecov/codecov-action/5ecb98a3c6b[74](https://github.com/google/osv-scanner/actions/runs/8978083643/job/24657957118#step:5:77)7ed38dc09f787459979aebb39be/dist/codecov' failed with exit code 1

josieang avatar May 07 '24 01:05 josieang

We seem to be getting these errors every now and then, current workaround is just rerun the tests

another-rex avatar May 07 '24 01:05 another-rex