google
test: add cases for output functions
This introduces a set of crafted scanner results that each supported output format is run through to showcase how they look across all the different results possible from a scanner run - it originally started life as the tests for #889 but I realised they could base used more generally for testing and reviewing all the outputters, so here we are.
~It looks like this has also revealed the SARIF output is unstable in its ordering, which I'll aim to address in a dedicated PR~
This is ready for review but #938 should be merged first.
Note that beyond the usual review of the technical implementation, reviewers should also review the test cases to make sure they're correct for the real world and are complete, and also review the snapshots for each outputs for any oddentities that we might want to change (for which dedicated issues should be created - they won't be addressed in this PR)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 63.94%. Comparing base (
9fee150) to head (e277400).
Additional details and impacted files
@@ Coverage Diff @@
## main #937 +/- ##
==========================================
+ Coverage 63.71% 63.94% +0.22%
==========================================
Files 146 146
Lines 11958 11958
==========================================
+ Hits 7619 7646 +27
+ Misses 3875 3854 -21
+ Partials 464 458 -6
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
fwiw the coverage output for this looks even better after #961 is landed, as it means we've got 100% coverage across most files in the package 😄