osv-scanner icon indicating copy to clipboard operation
osv-scanner copied to clipboard

Added installation instructions for Scoop

Open stevehipwell opened this issue 2 years ago • 5 comments

This PR adds installation instructions for using Scoop on Windows (https://github.com/ScoopInstaller/Main/pull/4231) which should make it nice and easy for anyone on a Windows machine to use this.

stevehipwell avatar Dec 16 '22 09:12 stevehipwell

@stevehipwell

Relates https://github.com/google/osv-scanner/issues/55

I don't know how Scoop works but does this repo update itself for new osv-scanner versions? To be more clear, when a new version of osv-scanner is released, the Scoop will search for a new osv-scanner, and will it be available on their repository?

jwillker avatar Dec 16 '22 17:12 jwillker

@jwillker Scoop keeps the package version up to date by watching the GH releases.

stevehipwell avatar Dec 16 '22 17:12 stevehipwell

@jwillker Scoop keeps the package version up to date by watching the GH releases.

On Windows, you would do "go install" as well. I am not sure of community acceptance of Scoop and why we need to introduce this layer of complexity when "go install" is the standard for installing go packages.

inferno-chromium avatar Dec 16 '22 18:12 inferno-chromium

@inferno-chromium that makes the assumption that all end users are expected to have the Go toolchain installed?

Scoop is pretty widely adopted for portable binaries; it adds zero additional complexity for projects and keeps versions up to date. I think it's worth adding to the README as osv-scanner is already available on Scoop.

I've generally found that the more ways there are to install binaries the better the adoption; and package managers which allow versions to be kept up to date are a good thing.

stevehipwell avatar Dec 16 '22 19:12 stevehipwell

@inferno-chromium that makes the assumption that all end users are expected to have the Go toolchain installed?

Scoop is pretty widely adopted for portable binaries; it adds zero additional complexity for projects and keeps versions up to date. I think it's worth adding to the README as osv-scanner is already available on Scoop.

I've generally found that the more ways there are to install binaries the better the adoption; and package managers which allow versions to be kept up to date are a good thing.

Make sense. I would let @oliverchang @another-rex come back from vacation to comment here. This seems fine, i think you should move it after source section, in a dedicated "Install from package manager section" and underneath it, give bullet point on Scoop. We will be adding more package manager ways soon, so it makes sense there.

inferno-chromium avatar Dec 16 '22 19:12 inferno-chromium

@inferno-chromium as the primary installation method in the current README is to downloading the binaries from the releases page wouldn't the package manager options logically follow next with installation from source remaining last?

stevehipwell avatar Dec 18 '22 20:12 stevehipwell

/gcbrun

another-rex avatar Dec 18 '22 22:12 another-rex