osv-scanner icon indicating copy to clipboard operation
osv-scanner copied to clipboard

consider putting details about errors in `models.VulnerabilityResults`

Open josieang opened this issue 2 years ago • 4 comments

This was discussed in: https://github.com/google/osv-scanner/pull/501#discussion_r1401646226

Return error codes don't seem to be the right way to report what combination of vulnerability, called vulnerabilities, license violations. It's simpler to just return 0 or 1, and put the details about what kinds of issues are present in the json or models.VulnerabilityResults output.

josieang avatar Nov 23 '23 12:11 josieang

This issue has not had any activity for 60 days and will be automatically closed in two weeks

github-actions[bot] avatar Jul 19 '24 18:07 github-actions[bot]

Automatically closing stale issue

github-actions[bot] avatar Aug 02 '24 19:08 github-actions[bot]

@cuixq would this be interesting for v2?

oliverchang avatar Aug 07 '24 02:08 oliverchang

yes, we would like to re-design error types in v2 https://github.com/google/osv-scanner/issues/636, and this is related.

cuixq avatar Aug 07 '24 02:08 cuixq