oss-fuzz icon indicating copy to clipboard operation
oss-fuzz copied to clipboard
verified publisher icon google

Set sanitizers to none

Open zi0Black opened this issue 1 year ago • 4 comments

While doing other build tests, I saw that building without ASAN works just fine. I want to disable it to gain performance.

zi0Black avatar Jul 29 '24 15:07 zi0Black

zi0Black has previously contributed to projects/aptos-core. The previous PR was #11512

github-actions[bot] avatar Jul 29 '24 15:07 github-actions[bot]

@jonathanmetzman @DavidKorczynski can I get this merged? :)

zi0Black avatar Jul 31 '24 18:07 zi0Black

Could you fix the breaking coverage build?

DavidKorczynski avatar Aug 19 '24 10:08 DavidKorczynski

Could you fix the breaking coverage build?

Error: Process completed with exit code 137., the container is running out of memory @DavidKorczynski :( I see the workflow disables swapping memory to save space on the disk, aptos-core is quite a big project, and we already had issue with running out of memory while building/linking.

zi0Black avatar Aug 19 '24 14:08 zi0Black

@jonathanmetzman @DavidKorczynski since I had to upgrade a dependency, I pushed the commit here trying to push everything together.

zi0Black avatar Nov 18 '24 13:11 zi0Black

Sorry, I shouldn't have landed this. I didn't realize it is a rust projects. Rust projects must use ASAN in OSS-Fuzz. This passed CI because nothing built :facepalm: I'm going to have to revert this.

jonathanmetzman avatar Nov 20 '24 17:11 jonathanmetzman