oss-fuzz icon indicating copy to clipboard operation
oss-fuzz copied to clipboard

Suggestion to add a note in documentation about LLVMFuzzerTestOneInput return value support by Honggfuzz.

Open kasper93 opened this issue 1 year ago • 1 comments

LibFuzzer supports rejecting unwanted inputs with return -1 https://llvm.org/docs/LibFuzzer.html#rejecting-unwanted-inputs One may read this documentation and implement fuzzers that return -1 from LLVMFuzzerTestOneInput. Problem is, Honggfuzz has never been updated to support this and any other return value than 0 is fatal error. LOG_F calls exit(EXIT_FAILURE) https://github.com/google/honggfuzz/blob/348a47213919f14b9453e89a663b1515369bd9a2/libhfuzz/persistent.c#L67

Maybe it is on fuzzers developer to know that, but in my opinion would be nice to have a note/warning about this and if possible update Honggfuzz to at lest not exit on -1. Also it could be reported somehow, now it just resets the persistent process and goes on without feedback, except log file.

kasper93 avatar May 21 '24 04:05 kasper93

This is a good find. I'm not really sure where we would put it though in the docs, but we are happy to accept any PRs :-)

Even better would be upstreaming a patch to honggfuzz to accept this behavior :-)

jonathanmetzman avatar Jun 05 '24 18:06 jonathanmetzman

Addressed in #12955 by @phi-go

DonggeLiu avatar Jan 27 '25 10:01 DonggeLiu