oss-fuzz icon indicating copy to clipboard operation
oss-fuzz copied to clipboard

Get ntp-dev fuzzing again

Open hart-NTP opened this issue 1 year ago • 13 comments

Update fuzz patch for ntp source changes. (issue 59213). Speed one-shot build by sharing config.cache between our 4 configure scripts and disabling dependency tracking. Add Dave Hart and Harlan Stenn to auto_ccs to enable authenticated access to gsutil.

hart-NTP avatar Feb 11 '24 06:02 hart-NTP

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Feb 11 '24 06:02 google-cla[bot]

hart-NTP is a new contributor to projects/ntp. The PR must be approved by known contributors before it can be merged. The past contributors are: joycebrum, devtty1er, Dor1s, catenacyber (unverified)

github-actions[bot] avatar Feb 11 '24 06:02 github-actions[bot]

@DonggeLiu could you trigger CI please ?

catenacyber avatar Feb 12 '24 20:02 catenacyber

Thanks, the failing CI runs are due to a bug I've fixed but hasn't been released yet. I will check back after the corrected ntp-dev is released.

[Bug 3835] NTP_HARD_*FLAGS not used by libevent tearoff. [email protected] https://bugs.ntp.org/3835

hart-NTP avatar Feb 13 '24 11:02 hart-NTP

@DonggeLiu could you trigger CI please ?

I've pushed a workaround to hart-NTP/oss-fuzz , would you please, would you please approve the workflow again?

hart-NTP avatar Feb 24 '24 21:02 hart-NTP

Could you fix the errors please?

jonathanmetzman avatar Mar 12 '24 15:03 jonathanmetzman

@DonggeLiu please trigger CI again. The corrected ntp-dev was finally released.

hart-NTP avatar May 29 '24 11:05 hart-NTP

@catenacyber @DonggeLiu can one of you help approve this to run CI again?

hart-NTP avatar May 30 '24 14:05 hart-NTP

@catenacyber @DonggeLiu can one of you help approve this to run CI again?

done

DavidKorczynski avatar May 30 '24 14:05 DavidKorczynski

Thanks @DavidKorczynski, my earlier attempted workaround for the brokenness in ntp-dev fouled some of the CI runs. I've reverted it and need an approving review to trigger CI again.

hart-NTP avatar May 31 '24 22:05 hart-NTP

@catenacyber @DavidKorczynski can one of you review to trigger CI please?

hart-NTP avatar Jun 03 '24 17:06 hart-NTP

@catenacyber @DavidKorczynski can one of you review to trigger CI please?

Done!

DavidKorczynski avatar Jun 03 '24 18:06 DavidKorczynski

You can also test the build locally (or in a virtual machine, if you want to keep you local machine clean) with docker python and git installed. See https://google.github.io/oss-fuzz/advanced-topics/reproducing/#building-using-docker

Also, it may be possible to enable GitHub actions in your fork, to run the CI. But I haven't tried that.

maflcko avatar Jun 04 '24 10:06 maflcko