osdfir-infrastructure
osdfir-infrastructure copied to clipboard
google
init script does not check for correct permissions
Name and Version
latest
What environment are you using?
GKE
What steps will reproduce the bug?
- create a turbinia service account
- do NOT add the correct permissions
- run the init-gke.sh script
- When trying to use any gcp dftw recipe it will fail because of the wrong permissions.
Are you using any custom parameters or values?
No response
What is the expected behavior?
I would expect the init script to verify if the correct permissions for the service account are assigned and assign them if not.
What do you see instead?
Turbinia will just fail with a permission error.
Additional information
No response
Not necessarily a bug but implementation choice as checking for the correct permissions is a bit more involved to do so opted to check for existence instead until we come up with a better way (which brought this edge case). Maybe in meantime can just add automatically even if it exists in case this comes up given default account anyways would be 'turbinia' unless they went into script and changed it which at that point they'd see that we add permissions to a GCP account as part of this before running the script.
