open-location-code icon indicating copy to clipboard operation
open-location-code copied to clipboard

Update JSON file access by karma/jasmine tests

Open drinckes opened this issue 5 years ago • 2 comments

Existing node JS tests (in js/test) use a combination of gulp and phantomjs to run.

phantomjs is now unsupported (and seems to be a pain to get working locally) so it would be good to refactor the tests to use karma/jasmine.

I've had a quick go at this but got stuck trying to get the test functions to access the CSV files. (If we have to we could convert them to JSON as part of the test script.)

drinckes avatar May 03 '19 09:05 drinckes

This is mostly done with #305. But this uses karma-jasmine-jquery which hasn't been updated for a long time, and has a lot of issues with pulling in old, obsolete dependencies.

So it would be good if someone with a bit more time and karma/jasmine experience could find a more up-to-date way to access JSON files from within tests.

drinckes avatar May 03 '19 13:05 drinckes

Recommended tag: implementation

fulldecent avatar Apr 25 '21 04:04 fulldecent