open-location-code icon indicating copy to clipboard operation
open-location-code copied to clipboard

C library could do with a rewrite

Open drinckes opened this issue 5 years ago • 3 comments

The code isn't very clear, arguments to functions aren't documented.

The function signatures are not very intuitive, I'd be ok if there was a rewrite without backward compatibility.

drinckes avatar Apr 24 '19 15:04 drinckes

Does this still require assistance? Just asking because it seems like a lot of changes occurred to the c library after (May 21st) this issue was opened.

shuklavk avatar Jul 02 '19 01:07 shuklavk

Hi @shuklavk, My comment was born out of a bit of frustration :-) I think the C code isn't all that easy to follow (the analyse() method for example).

Also the maxlen argument on most of the functions seems pretty superfluous?

If you wanted to take a look at it, that'd be cool!

drinckes avatar Jul 15 '19 09:07 drinckes

Recommended tag: implementation

fulldecent avatar Apr 25 '21 04:04 fulldecent