model-viewer icon indicating copy to clipboard operation
model-viewer copied to clipboard

Quicklook ar placement

Open pixlhero opened this issue 3 years ago • 10 comments

Fixes #3989

Also had to fix the boom_2_.glb model because the model was offset quite a lot, which messed with the rotation required for quicklook AR.

I tried a few different approaches to reset the rotation of the model (like keeping a copy of the matrix). Only rotating it back worked for me though.

pixlhero avatar Jan 03 '23 16:01 pixlhero

@pixlhero Ping - are you planning to come back to this?

elalish avatar Feb 14 '23 00:02 elalish

@pixlhero Ping - are you planning to come back to this?

Not in the near future unfortunately. We worked around this issue by just not placing it on the wall in our project. So until I have some spare time between projects I won't be able to work on this.

pixlhero avatar Feb 14 '23 15:02 pixlhero

@pixlhero - has this been fixed or still being worked on?

h36ahmed avatar Oct 13 '23 00:10 h36ahmed

any news how to enable vertical placement on IOS Quicklook?

ekokotov avatar Jan 24 '24 18:01 ekokotov

If anyone would like to take over this PR, it would be great to merge it. I may get to it eventually, but not sure when.

elalish avatar Jan 29 '24 20:01 elalish

Sorry about turning silent on this PR. I think I might be able to come back to this during next month. Probably not in the next two weeks though, but I put it in my calendar.

pixlhero avatar Jan 30 '24 13:01 pixlhero

Thanks!

elalish avatar Jan 31 '24 16:01 elalish

Working on this now 🚀

pixlhero avatar Mar 01 '24 09:03 pixlhero

Thanks! Let me know if you have any questions.

elalish avatar Mar 11 '24 15:03 elalish

I tested the changes here with model-viewer 3.4.0, it works fine for my models. But it seems we have an issue when auto-rotate attribute is used on model-viewer tag, the usdz generated has a different y rotation each time we generate the usdz, and after the 90° rotation here it gives really weird results. The bounding box seems wrong and will result of bad snapping on the wall, the shadow is ok but the model is not correctly on the wall.

vincentfretin avatar Apr 01 '24 17:04 vincentfretin