model-viewer icon indicating copy to clipboard operation
model-viewer copied to clipboard

Published 20 hours ago • verified publisher icon google

Create texture from canvas

Open lucadalli opened this issue 3 years ago • 3 comments

A naïve and incomplete attempt at #3211

I've never explored this part of the codebase so I'd like to hear your thoughts, particularly about using the canvas dataURL as the gltfImage uri, before I proceed any further.

Todo:

  • [x] Add a sister method alongside Image.setURI which accepts canvas input
  • [ ] Add example to docs

lucadalli avatar Feb 23 '22 13:02 lucadalli

Is this still a draft? Would you like to re-request review? I don't get pinged for commits, so I miss things sometimes...

elalish avatar Mar 07 '22 19:03 elalish

@elalish Still a draft, sorry. I'd like to add tests and an example to the docs before requesting review. Time I would've liked to spend on this PR went into creating a custom build based on v1.8 to work around issue #3193 :(

lucadalli avatar Mar 08 '22 11:03 lucadalli

Did you ever find the source of #3193? I'd like to get that fixed upstream. In any case, no rush and thanks for the contributions!

elalish avatar Mar 10 '22 00:03 elalish

I believe this has been addressed by #3886.

elalish avatar Jan 19 '23 19:01 elalish