model-viewer icon indicating copy to clipboard operation
model-viewer copied to clipboard

make sure the initial hit test angle is within the display field of view.

Open blairmacintyre opened this issue 4 years ago • 0 comments

https://github.com/google/model-viewer/blob/05e630c2994ad9698c75ef36d0d70fe12cdd1ed4/packages/model-viewer/src/three-components/ARRenderer.ts#L38

This line is fixed, and 20 degrees downward is probably ok on most phones in portrait mode (as the comments say). But some devices (e.g., iOS, using ARKit) can't hit test if the ray is offscreen. This will be an issue if Apple releases WebXR; current the WebXR Viewer implements WebXR and is limited in this way.

So perhaps compute an angle that is something like fovY / 2 * -.9 (or something) to pick and angle just above the bottom of the screen.

blairmacintyre avatar Jun 15 '20 20:06 blairmacintyre