mdbook-i18n-helpers
mdbook-i18n-helpers copied to clipboard
Update to mdbook 0.5
This is a preliminary PR for updating mdbook-i18n-helpers to mdbook 0.5. This should wait until at least mdbook 0.5 is released.
I haven't had a chance to do much testing, but the basics seem to work.
There is a migration guide that explains all the changes in the release.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Please update the relevant changelogs too.
Codecov Report
:x: Patch coverage is 18.51852% with 22 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 85.53%. Comparing base (886f15e) to head (191312f).
:warning: Report is 35 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 84.74% 85.53% +0.78%
==========================================
Files 15 17 +2
Lines 3377 3339 -38
Branches 3377 3339 -38
==========================================
- Hits 2862 2856 -6
+ Misses 413 381 -32
Partials 102 102
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
This looks reasonable and the tests pass, have you had a chance to do much manual testing?
I have not done significant testing. I mainly verified that a local copy of comprehensive-rust and rust-by-example worked with the mdbook-gettext preprocessor. The different languages seemed to appear as I expected. I also verified that mdbook-xgettext was able to extract the po files, but I didn't go beyond that.
If you have suggestions for more things for me to try, I'd be happy to do that. I wasn't really sure what to try.