maxtext icon indicating copy to clipboard operation
maxtext copied to clipboard

fixed integer check bug

Open grad0s opened this issue 1 year ago • 2 comments

the assertion doesn't check for determined_val being integer, missing function call.

grad0s avatar Nov 09 '23 06:11 grad0s

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Nov 09 '23 06:11 google-cla[bot]

Thank you good samaritan! This code looks good but annoyingly you need to sign the CLA for us to be allowed to merge it.

rwitten avatar Nov 14 '23 23:11 rwitten