material-design-icons icon indicating copy to clipboard operation
material-design-icons copied to clipboard

Web symbol for `star` doesn't have a non-fill version

Open joshjhall opened this issue 11 months ago • 5 comments

Entirely possible I'm missing something, but it appears the web version of the star symbol SVG is incorrect. Both the fill and non-fill versions have the fill SVG. The iOS and Android versions appear correct, so possibly limited to how the web SVG was generated. I also haven't noticed the issue with any other symbols, so it might be quite limited in scope. Note, star_rate appears correct.

For example, for star @ style=rounded, weight=400, fill=off, grade=normal, optical size=24dp Expected CleanShot 2024-03-26 at 12 32 11@2x

File in symbols/web/star/materialsymbolsrounded/star_24px.svg shows CleanShot 2024-03-26 at 12 36 10@2x

joshjhall avatar Mar 26 '24 17:03 joshjhall

The edit SVG also appears different than what's packaged in the font and such. Is the web SVG deprecated or out of date?

joshjhall avatar Mar 26 '24 21:03 joshjhall

Hmmm. I remember the default state for /star got changed a while back (as in, last year IIRC). Seems like maybe the SVG did not get regenerated.

/edit is also one that has been changed in the past year or so.

@EsoFromTheEast is this something you could address?

tphinney avatar Mar 26 '24 22:03 tphinney

Found another one this morning, emergency. May help track down when the SVG stopped regenerating.

joshjhall avatar Mar 27 '24 15:03 joshjhall

Thanks @tphinney and @EsoFromTheEast!

https://github.com/google/material-design-icons/issues/1531 might be the same issue. It appears the SVG for pause is still out of date compared with the font and Figma sources as well.

joshjhall avatar Mar 27 '24 23:03 joshjhall

edit_document and star_half are also out of date

joshjhall avatar Apr 02 '24 17:04 joshjhall

This should at last be fixed now?

tphinney avatar May 05 '24 04:05 tphinney

I believe this is fixed. Let us know if not!

tphinney avatar May 14 '24 04:05 tphinney

Confirmed it's fixed in the big update pushed master at the end of May a few days ago. I don't believe it'd been pushed to the branch until the update last week, but we're good to go now. Thanks!

joshjhall avatar Jun 03 '24 20:06 joshjhall