martian icon indicating copy to clipboard operation
martian copied to clipboard

go.mod cleanup

Open nohajc opened this issue 2 years ago • 3 comments

Out-of-sync go.mod with a reference to unused old version of protoc-gen-go-grpc causes a false positive finding in OWASP dependency-check.

Running go mod tidy fixes the issue. Also fixes #327.

nohajc avatar Jul 26 '22 16:07 nohajc

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 26 '22 16:07 google-cla[bot]

Hi @nohajc looks like the PR is not merged because of https://github.com/google/martian/pull/344#issuecomment-1195738697

Would you be able to comply to these requirements?

CarstenLeue avatar Feb 02 '24 16:02 CarstenLeue

Hello, this PR seems to be outdated as there are merge conflicts. The only thing I did was to run go mod tidy and submitted the result.

If this library is maintained again, I think it will be easier for you to close this PR and repeat the same steps on master (in case it's still needed).

nohajc avatar Feb 02 '24 18:02 nohajc