magika icon indicating copy to clipboard operation
magika copied to clipboard

Published 20 hours ago • verified publisher icon google

Support for SRT file detection

Open doggy8088 opened this issue 1 year ago • 5 comments

SRT files are a common file format used to create subtitles. Magika seems not able to detect *.srt file.

doggy8088 avatar Feb 19 '24 06:02 doggy8088

srt file is not listed in supported files

devilkadabra69 avatar Feb 19 '24 08:02 devilkadabra69

Thanks! would you mind adding more details about the SRT file format? We now have a github issue template with the info that would be very helpful: https://github.com/google/magika/blob/main/.github/ISSUE_TEMPLATE/new_content_type_request.md

Thanks!

reyammer avatar Feb 19 '24 15:02 reyammer

ok so i have to add more details into new_content_type_request.md ? or i have to rewrite it from scratch ?

devilkadabra69 avatar Feb 19 '24 19:02 devilkadabra69

@devilkadabra69 / @doggy8088 if you could create a new issue with the proper information (eg, where to find samples, context on the content type, etc.), it would be very useful for tracking. Once this is done, please close this one to avoid duplicates. Thank you!

reyammer avatar Feb 20 '24 10:02 reyammer

Ok. I'll provide full context and examples in the coming days.

doggy8088 avatar Feb 21 '24 00:02 doggy8088

See #176 for more context. Thanks @doggy8088!

reyammer avatar Feb 21 '24 08:02 reyammer