magika icon indicating copy to clipboard operation
magika copied to clipboard

Removed MIME Type Column from supported list

Open devilkadabra69 opened this issue 1 year ago • 3 comments

new colums are ->Index, Content Type Label ,Description

devilkadabra69 avatar Feb 20 '24 08:02 devilkadabra69

We also need to remove the Column from here as well: https://github.com/google/magika/blob/a9d3904fbe1523c740ecb20ebf0e742e4acf5892/python/magika/cli/magika.py#L432 It's shown when user use magika --list-output-content-types

nhonx avatar Feb 20 '24 10:02 nhonx

Thanks for the PR folks! The issue I've created was more of a "think about it" rather than "let's do it for sure" :-) but I still think it's a good idea. Maybe we should add a short discussion at the beginning or end of the table to justify this / point whoever sees the table to the discussion on output format. I need to think a bit about this...

reyammer avatar Feb 20 '24 13:02 reyammer

i guess i missed headers part ! i'll fix it quickly

devilkadabra69 avatar Feb 20 '24 17:02 devilkadabra69

Thanks!

reyammer avatar Feb 21 '24 08:02 reyammer