Light gray on white is no good

[BartMassey]

I use a "light-mode" terminal, with a white background. The very light gray used by low-quality detection reports works very poorly there. A little more contrast would be really helpful for this use case.

[reyammer]

@ia0, thoughts?

[ia0]

We can't detect how the user decides to render the terminal colors, so I see a few options to address this issue:

• Add a --light-mode flag or similar and use a different set of colors.
• Provide full control to the user for which color to use for each group. This could be --color-file=PATH where PATH is a file with a simple space-separated format like <group name> <red> <green> <blue> (one line per group).

In both cases, users should alias magika to their preference, e.g. alias magika='magika --light-mode'. Otherwise we would need to have configuration files and I believe this might be too overkill (but is an option otherwise).

[BartMassey]

Perhaps just choose a color scheme that is likely to be visible on a white background? Darkening the gray should solve the problem nicely, without being too hard to see on a dark background.

[ia0]

Sounds good to me.

Also another option is to use the terminal palette instead of true colors (we used to do that in the past) so the user has much more control.

@reyammer @ebursztein preferences?

[BartMassey]

(Just so you know, I probably won't alter my terminal palette to make your app work for me. Sad, but there it is.)

[ia0]

You shouldn't need to. There's only a few colors and you must already have seen them by using the color output of git or really any other command with colored output. So if they're not good you would already know. I think using the palette is the safest choice.