leveldb icon indicating copy to clipboard operation
leveldb copied to clipboard

Fix build break on system without O_CLOEXEC

Open stepinto opened this issue 2 years ago • 2 comments

On system without O_CLOEXEC, HAVE_O_CLOEXEC is defined as 0 in include/port/port_config.h, not undefined. Therefore, the right way to test it is "#if HAVE_O_CLOEXEC" rather than "#if defined(...)".

stepinto avatar Oct 01 '23 01:10 stepinto

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 01 '23 01:10 google-cla[bot]

Also see https://github.com/google/leveldb/pull/1028.

hebasto avatar Nov 05 '23 10:11 hebasto