leveldb icon indicating copy to clipboard operation
leveldb copied to clipboard

fix macro HAVE_O_CLOEXEC when O_CLOEXEC not found

Open emptyx0 opened this issue 3 years ago • 5 comments

port_config.h define HAVE_O_CLOEXEC is 0 when O_CLOEXEC not found in fcntl.h, so condition '#if defined(HAVE_O_CLOEXEC)' hit. It could be verified on centos5

emptyx0 avatar Jun 09 '22 06:06 emptyx0

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 09 '22 06:06 google-cla[bot]

macro HAVE_O_CLOEXEC is defined automatic by cmake in file port_config.h.in, cmake will define HAVE_O_CLOEXEC equals 0, so #if directive on HAVE_O_CLOEXEC in file env_posix.cc should be '#if HAVE_O_CLOEXEC' , not '#if defined(HAVE_O_CLOEXEC)',

emptyx0 avatar Jun 25 '22 03:06 emptyx0

@emptyx0 Did you want to sign the CLA?

maflcko avatar Jun 29 '22 13:06 maflcko

@emptyx0 Did you want to sign the CLA?

I have already signed the CLA , 3Q dalao

emptyx0 avatar Jun 30 '22 01:06 emptyx0

Also see https://github.com/google/leveldb/pull/1149.

hebasto avatar Nov 05 '23 10:11 hebasto