langextract icon indicating copy to clipboard operation
langextract copied to clipboard

ollama: send keep_alive at top level

Open chinmaynadgir opened this issue 2 months ago • 10 comments

fixes #256 This PR aligns the Ollama provider with the Ollama API by sending keep_alive at the payload’s top level while keeping options.keep_alive for backward compatibility.

Changes Provider: compute keep_alive once, set payload['keep_alive'] and options['keep_alive'].

Tests: in tests/inference_test.py: test_ollama_extra_kwargs_passed_to_api: assert payload['keep_alive'] == 600. test_ollama_defaults_when_unspecified: assert payload['keep_alive'] == 300.

Compatibility Backward-compatible: options.keep_alive is still present. No breaking API changes.

chinmaynadgir avatar Oct 18 '25 06:10 chinmaynadgir

⚠️ Branch Update Required

Your branch is 1 commits behind main. Please update your branch to ensure CI checks run with the latest code:

git fetch origin main
git merge origin/main
git push

Note: Enable "Allow edits by maintainers" to allow automatic updates.

github-actions[bot] avatar Oct 30 '25 06:10 github-actions[bot]

⚠️ Branch Update Required

Your branch is 3 commits behind main. Please update your branch to ensure CI checks run with the latest code:

git fetch origin main
git merge origin/main
git push

Note: Enable "Allow edits by maintainers" to allow automatic updates.

github-actions[bot] avatar Nov 07 '25 02:11 github-actions[bot]

⚠️ Branch Update Required

Your branch is 4 commits behind main. Please update your branch to ensure CI checks run with the latest code:

git fetch origin main
git merge origin/main
git push

Note: Enable "Allow edits by maintainers" to allow automatic updates.

github-actions[bot] avatar Nov 14 '25 22:11 github-actions[bot]

⚠️ Branch Update Required

Your branch is 8 commits behind main. Please update your branch to ensure CI checks run with the latest code:

git fetch origin main
git merge origin/main
git push

Note: Enable "Allow edits by maintainers" to allow automatic updates.

github-actions[bot] avatar Nov 22 '25 02:11 github-actions[bot]

⚠️ Branch Update Required

Your branch is 10 commits behind main. Please update your branch to ensure CI checks run with the latest code:

git fetch origin main
git merge origin/main
git push

Note: Enable "Allow edits by maintainers" to allow automatic updates.

github-actions[bot] avatar Nov 29 '25 02:11 github-actions[bot]

⚠️ Branch Update Required

Your branch is 10 commits behind main. Please update your branch to ensure CI checks run with the latest code:

git fetch origin main
git merge origin/main
git push

Note: Enable "Allow edits by maintainers" to allow automatic updates.

github-actions[bot] avatar Dec 07 '25 02:12 github-actions[bot]

⚠️ Branch Update Required

Your branch is 10 commits behind main. Please update your branch to ensure CI checks run with the latest code:

git fetch origin main
git merge origin/main
git push

Note: Enable "Allow edits by maintainers" to allow automatic updates.

github-actions[bot] avatar Dec 14 '25 02:12 github-actions[bot]

Hey, just checking on this. Is there any issues with the code?

woofy0 avatar Dec 19 '25 03:12 woofy0