json_serializable.dart icon indicating copy to clipboard operation
json_serializable.dart copied to clipboard

Published 20 hours ago • verified publisher icon google

Fix bool? casted to bool.

Open qwe321 opened this issue 1 year ago • 2 comments

Question mark was missing in case of optional bool field.

qwe321 avatar Aug 14 '24 21:08 qwe321

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 14 '24 21:08 google-cla[bot]

We'll really want test coverage here!

kevmoo avatar Aug 14 '24 21:08 kevmoo

Need the CLA signed and please add a test!

kevmoo avatar Jan 02 '25 17:01 kevmoo

Without additional information we're not able to resolve this PR. Feel free to add more info or respond to any questions above. Thanks for your contribution!

github-actions[bot] avatar Jan 17 '25 08:01 github-actions[bot]

I'm sorry I cannot reproduce it anymore on recent versions. It seems it cause was somewhere else

qwe321 avatar Jan 17 '25 11:01 qwe321