jaxopt icon indicating copy to clipboard operation
jaxopt copied to clipboard

Fix `BoxOSQP` when configured with `fun` and used with pytree-based APIs

Open diegoferigo opened this issue 1 year ago • 3 comments

The combined usage of Pytree of matrices API and Quadratic function API is currently broken due to a missing operation performed on generic pytrees. This PR updates the operation to be performed with the existing pytree helpers.

diegoferigo avatar May 17 '24 15:05 diegoferigo

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 17 '24 15:05 google-cla[bot]

Failures in CI seem unrelated to the changes of this PR. The osqp_test.py, only test affected by the proposed changes, is passing.

diegoferigo avatar May 17 '24 15:05 diegoferigo

Friendly ping @Algue-Rythme, any comment on this tiny PR?

diegoferigo avatar Jun 05 '24 14:06 diegoferigo