jaxopt icon indicating copy to clipboard operation
jaxopt copied to clipboard

Fix: parse tol to scipy minimize.

Open pipme opened this issue 3 years ago • 3 comments

tol is not parsed to scipy.optimize.minimize in ScipyMinimize.

pipme avatar Aug 01 '22 12:08 pipme

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 01 '22 12:08 google-cla[bot]

Thanks for spotting and for the contribution! It seems that the test test_logreg_with_intercept is now failing. Can you fix it and force-push? Thanks!

mblondel avatar Aug 11 '22 10:08 mblondel

Hi, I changed the tol from 1e-3 to 1e-5 and now the test is passed.

pipme avatar Aug 11 '22 11:08 pipme