jax icon indicating copy to clipboard operation
jax copied to clipboard

[ROCm] Add float8_e4m3fnuz test

Open Ruturaj4 opened this issue 1 year ago • 4 comments
trafficstars

Ruturaj4 avatar Apr 23 '24 04:04 Ruturaj4

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 23 '24 04:04 google-cla[bot]

@jakevdp can you review this please

Ruturaj4 avatar Apr 23 '24 15:04 Ruturaj4

Can you say more about why you want to enable this test? It's only testing dot_general with preferred_element_type – we do have other coverage for dot_general without this argument.

jakevdp avatar Apr 23 '24 19:04 jakevdp

@jakevdp Thanks for your comments. I revised the patch. Currently only enabled for rocm.

Ruturaj4 avatar May 17 '24 05:05 Ruturaj4