jax-cfd icon indicating copy to clipboard operation
jax-cfd copied to clipboard

Fixed Taylor Green decay coefficient and added an example

Open scaomath opened this issue 1 year ago • 2 comments

The scale for the Taylor Green example should be $\exp(-(k_x^2 +k_y^2) \nu t )$, otherwise the factor coming out from $\partial_t \mathbf{u}$ cannot be canceled with $\nu\Delta \mathbf{u}$. An example notebook computing the error with analytical solution is added as well.

scaomath avatar May 18 '24 01:05 scaomath

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 18 '24 01:05 google-cla[bot]

@shoyer

scaomath avatar May 19 '24 00:05 scaomath