ide-perf icon indicating copy to clipboard operation
ide-perf copied to clipboard

VFS Tracer broke

Open SamB opened this issue 3 years ago • 1 comments

Worse, the error message is unreadable (the text is confined to an itty-bitty square somehow). However, thanks to the UI Inspector, I can recover the HTML for the error message. (The whitespace was somewhat mangled, so I've tweaked it.)

<html>
   <head>
     <style type="text/css">
       <!--
         body { font-family: Segoe UI; font-size: 12pt; color: #d4d4d4 }
         div { font-family: Segoe UI; font-size: 12pt; color: #d4d4d4 }
         td { font-family: Segoe UI; font-size: 12pt; color: #d4d4d4 }
         p { font-family: Segoe UI; font-size: 12pt; color: #d4d4d4 }
         a { font-family: Segoe UI; font-size: 12pt; color: #ede891 }
         code { font-size: 12pt }
         ul { list-style: disc; margin-left: 15px }
       -->
     </style>
   </head>
   <body>
     Detected a breaking change. Cannot find
      com.intellij.psi.stubs.StubIndexImpl::createPsiNoLock.
   </body>
 </html> 

However, it seems that this instance of createPsiNoLock is a copy and paste error: the method in question is actually named processElements:

https://github.com/google/ide-perf/blob/3610383c3ad69b7ad0509a881a033687a01194fa/src/main/java/com/google/idea/perf/vfstracer/VirtualFileTracer.kt#L252

It looks like this got moved to com.intellij.psi.stubs.StubIndexEx#processElements in commit https://github.com/JetBrains/intellij-community/commit/7aa4148d5e746e99fe42cb229f33928d7549e606.

SamB avatar May 26 '22 22:05 SamB

Thank you for the very detailed report! I'll try to get to this soon. It looks like an easy fix, but I also want to add some test coverage for the VFS tracer (currently there is very little).

p.s. the VFS tracer is relatively experimental and hasn't received very much usage yet. So if you have used it in the past, please let me know how it went / whether it was useful!

gharrma avatar Jun 01 '22 14:06 gharrma