horologist icon indicating copy to clipboard operation
horologist copied to clipboard

Utilities for round device padding

Open yschimke opened this issue 2 years ago β€’ 5 comments

For example Modifier.roundDevicePadding(width = 1f). This is sometimes neccesary to add to the final item to ensure it can be scrolled high enough to be not cutoff.

See this clumsy fix https://github.com/joreilly/PeopleInSpace/pull/131/files

Similar to API at https://google.github.io/accompanist/insets/ for insets.

yschimke avatar May 20 '22 13:05 yschimke

cc @saryongkang

yschimke avatar May 20 '22 13:05 yschimke

Got it. I'm gonna start for it next Thu (June 26). ;)

saryongkang avatar May 21 '22 07:05 saryongkang

Is this being worked on by any chance? πŸ˜„ Is this something you would like to have in /compose-tools? :)

oas004 avatar Sep 18 '22 17:09 oas004

compose-tools is more previews and testing tools.

Probably compose-layout. I don't think we have a clear API in mind yet. I'm a bit wary if we don't have someone screaming for it, and ready to use it.

We should have some sample ideas in mind, such as ensuring the final item in a list is high enough to not be cutoff on the sides. Or maybe something in between fillMaxSize and fillMaxRectangle?

yschimke avatar Sep 18 '22 18:09 yschimke

compose-tools is more previews and testing tools.

Probably compose-layout. I don't think we have a clear API in mind yet. I'm a bit wary if we don't have someone screaming for it, and ready to use it.

We should have some sample ideas in mind, such as ensuring the final item in a list is high enough to not be cutoff on the sides. Or maybe something in between fillMaxSize and fillMaxRectangle?

That makes sense!😊 I think ensuring the final item is high enough to not be cut off is a nice idea😊

oas004 avatar Sep 19 '22 06:09 oas004

Out of scope for now

yschimke avatar Mar 13 '23 16:03 yschimke