highway icon indicating copy to clipboard operation
highway copied to clipboard

Published 20 hours ago • verified publisher icon google

Run convert_test/TestIntFromFloatHuge again on neon

Open malaterre opened this issue 2 years ago • 2 comments

malaterre avatar Aug 05 '22 07:08 malaterre

The above patch has been integrated in debian package since 7/7/2022 with no failures neither on gcc-11 nor on gcc-12:

  • https://salsa.debian.org/debian-phototools-team/highway/-/blob/master/debian/patches/neon.patch

Reference:

SCALAR+NEON:

  • https://buildd.debian.org/status/fetch.php?pkg=highway&arch=armhf&ver=1.0.0-5&stamp=1659598256&raw=0

EMU128+NEON:

  • https://buildd.debian.org/status/fetch.php?pkg=highway&arch=armhf&ver=1.0.1%7Egit20220802.5810c58-4&stamp=1659618390&raw=0

malaterre avatar Aug 05 '22 07:08 malaterre

Nice, thanks for re-enabling it. Would you mind updating the comment before it as well (removing mention of Arm?)

jan-wassenberg avatar Aug 05 '22 08:08 jan-wassenberg

would be nice to have this for 1.0.1. thanks

malaterre avatar Aug 16 '22 16:08 malaterre

Thanks for following up :) I was hoping we'd also change the comment (which still mentions ArmV7 as being broken). I'll do that in a separate PR shortly.

jan-wassenberg avatar Aug 17 '22 08:08 jan-wassenberg

Unfortunately this is still failing for us in clang + Arm7 32-bit. Let's re-enable only for GCC then.

jan-wassenberg avatar Aug 17 '22 08:08 jan-wassenberg

closing since fixed in 0a9ec963b8478c45af963e78eb65e332fb4d07d7

malaterre avatar Aug 17 '22 12:08 malaterre