highway icon indicating copy to clipboard operation
highway copied to clipboard

fix compile error on arm32 (missing float64x1_t type)

Open troyliu0105 opened this issue 1 year ago • 1 comments

this small commit fixes compiling error on some arm32 devices. cuz lack of float64x1_t definition. ( float64x1_t is only available on aarch64 document).

[build] In file included from /workspaces/demo/builds/release/_deps/highway-src/hwy/highway.h:588:0,
[build]                  from /workspaces/demo/builds/release/_deps/highway-src/hwy/timer-inl.h:26,
[build]                  from /workspaces/demo/builds/release/_deps/highway-src/hwy/nanobenchmark.cc:28:
[build] /workspaces/demo/builds/release/_deps/highway-src/hwy/ops/arm_neon-inl.h:2494:12: error: ‘float64x1_t’ does not name a type
[build]  HWY_INLINE float64x1_t vrecpe_f64(float64x1_t raw) {
[build]             ^~~~~~~~~~~
[build] ninja: build stopped: subcommand failed.

so the additional HWY_HAVE_FLOAT64 is added to determine whether the vrecpe_f64 func should be defined.

troyliu0105 avatar Aug 09 '24 02:08 troyliu0105

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 09 '24 02:08 google-cla[bot]

Why hasn't this pull request been already merged?

johnplatts avatar Nov 02 '24 12:11 johnplatts

Checking, thanks for following up..

jan-wassenberg avatar Nov 04 '24 09:11 jan-wassenberg

Compile logs have already been deleted but it looks like a build timeout is at least contributing to failing internal CI and preventing the merge. Retrying..

jan-wassenberg avatar Nov 04 '24 09:11 jan-wassenberg

Yes, looks like it was a build timeout.

jan-wassenberg avatar Nov 04 '24 10:11 jan-wassenberg