highway icon indicating copy to clipboard operation
highway copied to clipboard

Published 20 hours ago • verified publisher icon google

Remove cast-align warnings

Open malaterre opened this issue 1 year ago • 1 comments

malaterre avatar Oct 13 '23 09:10 malaterre

@jan-wassenberg I could not come up with something more elegant. Anyway I believe those are the only remaining issues before we can add -Wcast-align to the list of compilation flags when compiling hwy

malaterre avatar Oct 13 '23 09:10 malaterre

Hi @malaterre , would you mind rebasing?

jan-wassenberg avatar Mar 19 '24 23:03 jan-wassenberg

Thanks! I checked with ubsan and we get test failures because we were checking for alignment to the pointer type, not to the pointed-to type. Fixing by adding RemovePtr.

jan-wassenberg avatar Mar 20 '24 12:03 jan-wassenberg

Rerunning CI now..

jan-wassenberg avatar Mar 25 '24 03:03 jan-wassenberg