highway icon indicating copy to clipboard operation
highway copied to clipboard

Published 20 hours ago • verified publisher icon google

Add VQSelect

Open zbjornson opened this issue 1 year ago • 3 comments

The monotonous work is done and the new test suite works for std::nth_element, but fails for VQSelect() - it's skipping an entire partition. I don't see the cause so far though. There are a few other TODOs within the code as well.

Direct edits and comments both welcome.

zbjornson avatar Sep 01 '23 22:09 zbjornson

@zbjornson would you like to make the minor change suggested? Otherwise I'm happy to do it after we merge.

jan-wassenberg avatar Oct 05 '23 14:10 jan-wassenberg

@jan-wassenberg sorry for going MIA. I keep hoping to find time to make the change, but haven't. Please go ahead with making the change if you don't mind (I have the PR set so that you can push to this branch also).

zbjornson avatar Nov 13 '23 18:11 zbjornson

I understand, we'll take care of it after merging. Thanks for implementing this :)

jan-wassenberg avatar Nov 27 '23 16:11 jan-wassenberg

Sorry to drop the ball on this :/ The merge had failed because a rebase was required, but I missed the notification. @zbjornson , any chance you could help update this PR? This would help @enum-class implement TopK in #2019 :)

jan-wassenberg avatar Mar 13 '24 02:03 jan-wassenberg

I have learned how to patch copybara changes to fix the compile error we were seeing (inserting the missing hwy::). Hopefully import will happen soon :)

jan-wassenberg avatar Mar 14 '24 00:03 jan-wassenberg

FYI the patch worked but we have an issue with MSVC which I am addressing in #2022 .

jan-wassenberg avatar Mar 14 '24 08:03 jan-wassenberg

This is now merged in #2024 with attribution. Thanks @zbjornson for implementing it :)

jan-wassenberg avatar Mar 19 '24 23:03 jan-wassenberg