Added Squat Packing's rotate and sum operation and resolved type mismatch issues.

Open copybara-service[bot] opened this issue 1 year ago • 1 comments

Sep 15 '24 02:09 copybara-service[bot]

I commented out a buggy tensor_ext canonicalization, which makes some tests fail in order to get some squat packing tests to pass. @asraa's code will fix it, and this commit may change as a result.

Sep 20 '24 23:09 lawrencekhlim

@asraa do you know what the status of this PR is? It looks like it's useful additions (squat packing) that aren't in main right now, but there's clearly also some conflicts/issues?

Nov 25 '24 12:11 AlexanderViand-Intel

Asra is out this week. I could try to cherry pick it and resolve the remaining issues, but with the holidays I'm not sure who on the Google side would be around to review.

Nov 25 '24 14:11 j2kun

This isn't urgent, so I'm happy to wait until Asra's back!

Nov 25 '24 14:11 AlexanderViand-Intel

Pinging @asraa again on this :)

Dec 16 '24 20:12 AlexanderViand-Intel

Asra is out until the new year. I don't think I'll have time to patch and finish this. It may just have to wait.

Dec 16 '24 21:12 j2kun

Superseeded by https://github.com/google/heir/pull/1269

Jan 15 '25 17:01 asraa