heir icon indicating copy to clipboard operation
heir copied to clipboard

tfhe_rust: improve generality of e2e test runner

Open j2kun opened this issue 2 years ago • 4 comments

  • Support generated functions with multiple return values
  • Support a variable number of input arguments (not just 2 ints)
  • Custom function name besides fn_under_test?

j2kun avatar Nov 07 '23 23:11 j2kun

Variadic args seems hard in rust because rust doesn't have a splat operator to read in the variadic CLI arguments and convert them to a static function signature. I thought maybe macro_rules would provide a workaround, but didn't have the time to figure it out.

j2kun avatar Nov 08 '23 00:11 j2kun

A colleague pointed me to this which might help support the variadic arguments issue: https://jsdw.me/posts/rust-fn-traits/

See the section "Accepting variable arity functions using Trait Families"

j2kun avatar Nov 09 '23 17:11 j2kun

This issue has 4 outstanding TODOs:

This comment was autogenerated by todo-backlinks

github-actions[bot] avatar Jan 12 '24 17:01 github-actions[bot]

Now that I've got the openfhe e2e tests working, it seems reasonable to migrate to proper rust rules and a rust test harness instead of lit testing.

j2kun avatar Feb 23 '24 04:02 j2kun