heir
heir copied to clipboard
[poly]: Use a default builder to make the encoding parameter optional
trafficstars
Right now poly.poly has a custom builder to get the defaults working properly, but tablegen is supposed to have native support for default valued attributes. I couldn't get it to work. See PolyTypes.td
This issue has 1 outstanding TODOs:
- lib/Dialect/Polynomial/IR/PolynomialTypes.td:30: Skip the default builder since the custom builder enables the
This comment was autogenerated by todo-backlinks
This has been removed in the upstream port of Polynomial, and from what I can tell it is unused in the codebase. I'm going to remove it for now so we can rethink how to track the encoding type across the IR. I think it might make more sense to use NTT/INTT for this.