heir icon indicating copy to clipboard operation
heir copied to clipboard

[poly]: Use a default builder to make the encoding parameter optional

Open j2kun opened this issue 2 years ago • 1 comments
trafficstars

Right now poly.poly has a custom builder to get the defaults working properly, but tablegen is supposed to have native support for default valued attributes. I couldn't get it to work. See PolyTypes.td

j2kun avatar Sep 29 '23 21:09 j2kun

This issue has 1 outstanding TODOs:

This comment was autogenerated by todo-backlinks

github-actions[bot] avatar Jan 12 '24 17:01 github-actions[bot]

This has been removed in the upstream port of Polynomial, and from what I can tell it is unused in the codebase. I'm going to remove it for now so we can rethink how to track the encoding type across the IR. I think it might make more sense to use NTT/INTT for this.

j2kun avatar May 23 '24 02:05 j2kun