gvisor icon indicating copy to clipboard operation
gvisor copied to clipboard

feat: add test for msgqueue

Open royalpinto007 opened this issue 2 years ago • 4 comments

Fixes- https://github.com/google/gvisor/issues/8872

royalpinto007 avatar Sep 13 '23 16:09 royalpinto007

I left some comments in #9369. I am curious what is the higher level goal of this change? Is this a starter task of some sort?

ayushr2 avatar Sep 13 '23 16:09 ayushr2

Note that the test will not run unless you modify the BUILD file to add the test to linux_test.

ayushr2 avatar Sep 13 '23 16:09 ayushr2

Hey @ayushr2,

Thank you for your valuable feedback and suggestion regarding the testing approach for the MsgInfo struct. Your input is greatly appreciated. I completely agree with your suggestion to incorporate higher-level end-to-end (E2E) testing, especially for message queues. As you mentioned, we already have some tests in test/syscalls/linux/msgqueue.cc, and I fully intend to build upon that foundation. And, I will add it to the BUILD file too, and yes this was a starter code for the test file, I will do the required changes.

royalpinto007 avatar Sep 13 '23 16:09 royalpinto007

A friendly reminder that this PR had no activity for 120 days.

github-actions[bot] avatar Jan 12 '24 00:01 github-actions[bot]

This PR has been closed due to lack of activity.

github-actions[bot] avatar Apr 11 '24 00:04 github-actions[bot]