gvisor icon indicating copy to clipboard operation
gvisor copied to clipboard

Compose tcp.endpoint with network.Endpoint

Open arthurpi opened this issue 3 years ago • 4 comments

Description

transport/internal/network.Endpoint implements common facilities shared to send/receive datagrams over a network protocol. UDP, ICMP, RAW endpoints are composed with that type.

We can treat each TCP segment as a network datagram, so tcp.endpoint can be composed by a transport/internal/network.Endpoint. This will lead to reduced code duplication.

Steps to reproduce

No response

runsc version

No response

docker version (if using docker)

No response

uname

No response

kubectl (if using Kubernetes)

No response

repo state (if built from source)

No response

runsc debug logs (if available)

No response

arthurpi avatar Dec 20 '21 20:12 arthurpi

A friendly reminder that this issue had no activity for 120 days.

github-actions[bot] avatar Sep 13 '23 00:09 github-actions[bot]

This issue has been closed due to lack of activity.

github-actions[bot] avatar Dec 12 '23 00:12 github-actions[bot]

There are TODOs still referencing this issue:

  1. pkg/tcpip/transport/tcp/endpoint.go:805: Remove once tcp endpoints are composed with a

Search TODO

github-actions[bot] avatar Dec 13 '23 00:12 github-actions[bot]

A friendly reminder that this issue had no activity for 120 days.

github-actions[bot] avatar Apr 11 '24 00:04 github-actions[bot]