guava icon indicating copy to clipboard operation
guava copied to clipboard

Use default error action for malformed input and unmappable characters

Open tobbi opened this issue 1 year ago • 5 comments

I have to preface this by saying that I'm quite new to this codebase. However, I looked through the issues list and fixing the linked issue seemed trivial enough so I gave it a shot.

Maybe, if things work out and I learn quickly, I might try tackling larger issues.

If anything else is needed, please go ahead and tell me.

Fixes #6944

tobbi avatar May 14 '24 05:05 tobbi

Sorry, we haven't gotten around to making a decision on #6944 yet.

Per https://github.com/google/guava/wiki/HowToContribute#code-contributions:

  1. Discuss the feature request until it is marked Accepted.

should happen before

  1. Implement the change.

chaoren avatar May 15 '24 15:05 chaoren

No problem. I guess I'll just wait, unless you decide to implement things yourself. Nonetheless, I'm interested in contributing. Are there any "good first issue"-type issues I could try?

tobbi avatar May 15 '24 15:05 tobbi

Filing and/or commenting on issues is probably the best way to contribute. We'd rather have everything hashed out completely before having anyone start working on an implementation.

chaoren avatar May 15 '24 16:05 chaoren

How do you mark feature requests as accepted? Does that happen on Github? At first glance I couldn't find a suitable label.

tobbi avatar May 15 '24 16:05 tobbi

Yeah, I also expected there to be a status=accepted label given the contribution guidelines. I'll check if we can get that label added.

chaoren avatar May 15 '24 18:05 chaoren