guava icon indicating copy to clipboard operation
guava copied to clipboard

PR: Fix #3720

Open u7305790 opened this issue 3 years ago • 2 comments

Add methods corresponding to the requirements in #3720 and tests

u7305790 avatar Oct 17 '22 02:10 u7305790

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 17 '22 02:10 google-cla[bot]

PR: Fix #3720

Update: indexOf(byte[] array, byte target, int fromIndex) [Byte.java] indexOf(byte[] array, byte[] target, int fromIndex) [Byte.java] lastIndexOf(byte[] array, byte target, int fromIndex) [Byte.java] lastIndexOf(byte[] array, byte[] target, int fromIndex) [Byte.java]

These 4 methods are written strictly according to the requirements of the issue #3720.

Unit Tests written: testIndexOf_arrayTarget_fromIndex() [ByteTest.java] testIndexOf_fromIndex() [ByteTest.java] testLastIndexOf_fromIndex() [ByteTest.java]

These tests try to cover a case coverage as comprehensively as possible.

I think the requirements of this issue have been met. If there are extra requirements or bugs exists, please just comment here.

Thanks for reviewing it!

u7305790 avatar Oct 27 '22 08:10 u7305790