guava icon indicating copy to clipboard operation
guava copied to clipboard

Change private access modifiers for constants in MediaType

Open scazacioc opened this issue 3 years ago • 2 comments

Change access modifier to public for

private static final String APPLICATION_TYPE = "application";
private static final String AUDIO_TYPE = "audio";
private static final String IMAGE_TYPE = "image";
private static final String TEXT_TYPE = "text";
private static final String VIDEO_TYPE = "video";

private static final String WILDCARD = "*";

scazacioc avatar May 07 '22 03:05 scazacioc

Is there a particular reason you want these made public? I'm not necessarily opposed, but it would mean having a mix of public MediaType and String constants in the class, which could be awkward. We'd also need Javadoc on the public fields, etc.

cgdecker avatar May 09 '22 14:05 cgdecker

The change is related to these issues : https://github.com/google/guava/issues/5794

scazacioc avatar May 09 '22 14:05 scazacioc