guava
guava copied to clipboard
google
Fixed double slicing ByteSource
Fixes #3501
However, there is still a problem in this method. If this.offset + this.length > Long.MAX_VALUE, it will overflow. These are 4 possible approaches:
- Leave is as it is.
- Disallow offset + length > Long.MAX_VALUE on slices by adding checks.
- Allow offsets larger than Long.MAX_VALUE.
- Assume that no ByteSource has that much elements, and if the offset would overflow, return an empty source.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
Somehow we ended up merging https://github.com/google/guava/pull/3829 instead of this one. Sorry about that.
