ground-android

ground-android copied to clipboard

Add a layer pop-up dialog for choose map layer and show the data layer

3

#936 Adding some initial UI to the map container to allow users to select map type and also show the data layers of the selected project. Next step: add some...

nmhung00

[Code health] Refactor main fragments

1

- [ ] Move behavior and state from HomeScreenFragment, MapContainerFragment, and others into view models. - [ ] Move logic into appropriate class. Namely, there's a lot of logic relating...

gino-m

[Code health] Fix duplicate / unclear EditObservation* flows

2

There are several problems with the lifecycle of `EditObservationFragment` and `EditObservationViewModel` while working on #1077: * `initialize()` is called when the ViewModel is being restored, even if it was already...

gino-m

Haven't tried to repro yet. Could these be caused by a feature deleted locally still being present on the map or open in the UI? ``` Non-fatal Exception: com.google.android.gnd.persistence.remote.NotFoundException: Feature...

gino-m

On Pixel 4, photo and data sync status notifications not appearing. Using debug build.

gino-m

To ensure subscriptions did not accumulate until a view or view model is destroyed, we previously only allowed calls to subscribe() in initializers that would only be called once per...

gino-m

`lastPhotoResult` in `EditObservationViewModel` replays the last value on subscribe, which will cause the `PhotoFieldViewModel` to upload the photo again. @shobhitagarwal1612 FYI.

gino-m

Some quick wins: * Inject and use EphemeralPopups directly instead of binding to Activity. * How errors are handled depends on the use case; expose finer-grained handlers, e.g. `handlePermissionDeniedErrors`. *...

gino-m

fix: show deletion mutations in sync status UI

1

Before, we cascaded deletions on the foreign keys for feature/observation mutations, meaning all mutations for a feature/observation were wiped from the DB, eradicating the user's edit/sync history. This change alters...

scolsen

[Add polygon] When drawing, last edge is only updated when map stops moving

4

We should update the edge on camera move rather than on drag finished. @shobhitagarwal1612 Also related to your last PR.. could you PTAL?

gino-m