ground-android

ground-android copied to clipboard

Exact UX TBD, would likely hide the sign in button and replace it with a message eg "Sign in unavailable while offline."

gino-m

[Add/edit photo] Field label not shown for photo fields

1

gino-m

Expected to see photos here, but instead they're handled as text fields: https://github.com/google/ground-android/blob/21e2292da587e068916abe641d90a51ce978f7e4/gnd/src/main/java/com/google/android/gnd/persistence/remote/firestore/schema/ObservationConverter.java#L71 @shobhitagarwal1612 Any idea how we can move the deserialization logic into the same place?

gino-m

[Data collection] Date/time/number fields don't respect user's preferred formats

2

We should use `android.text.format.DateFormat.getDateFormat(context)`, but `DateResponse` and `TimeResponse` are context-agnostic. Formatting should instead be done in the view layer, with the response objet's `String` representation used for debugging only. Fyi...

gino-m

[Code health] Add RX utility for handling errors and displaying them in the UI

1

@gino-m proposed adding an RX converter called `handleErrors` that would effectively serve the role of `doOnError`, `onErrorReturn`, and friends and do the following: 1. Catch an error emitted by a...

scolsen

Requested by @kdyson. See also https://github.com/google/ground-platform/issues/762

gino-m

[Data collection] First photo taken with camera doesn't appear

5

The first time a photo is taken, the user is prompted to go through the permissions flows. The camera appears, and the user can take photos, but upon taking a...

gino-m

[Save submission] Submissions w/no associated LOI sometimes found in local db

1

gino-m

We currently silently eat all remote data store errors. See https://github.com/google/ground-android/pull/274#discussion_r361377361 by @shobhitagarwal1612 .

gino-m

**To Reproduce** Steps to reproduce the behavior: 1. Open offline areas UI 2. Click back **Expected behavior** The map appears immediately without refetching tiles. **Actual behavior** Tiles are reloaded and...

gino-m